Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Web]support custom editor language height light #2451

Merged
merged 4 commits into from
Oct 28, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Oct 27, 2023

Purpose of the pull request

support custom editor language height light

Brief change log

Verify this pull request

暗色 (思路初步实现,细节再调整)
image

亮色(思路初步实现,细节再调整)
image

zhu-mingye and others added 4 commits October 27, 2023 16:59
# Conflicts:
#	dinky-web/src/components/CustomEditor/CodeShow/index.tsx
#	dinky-web/src/components/CustomEditor/languages/javalog/index.tsx
#	dinky-web/src/pages/DataStudio/BottomContainer/Console/ConsoleContent.tsx
@Zzm0809 Zzm0809 requested a review from zackyoungh October 27, 2023 20:05
@Zzm0809 Zzm0809 self-assigned this Oct 27, 2023
@Zzm0809 Zzm0809 added the New Feature New feature label Oct 27, 2023
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Oct 27, 2023
Copy link
Contributor

@zackyoungh zackyoungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackyoungh zackyoungh changed the title support custom editor language height light [Feature][Web]support custom editor language height light Oct 28, 2023
@zackyoungh zackyoungh merged commit c3effad into DataLinkDC:dev Oct 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants