Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization][admin] Mark some unused methods with @Deprecated and add some methods without annotations #2379

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

zhangyongtian
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 requested review from zackyoungh and leechor October 12, 2023 09:03
@Zzm0809 Zzm0809 added the Refactor refactor code label Oct 12, 2023
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Oct 12, 2023
Copy link
Contributor

@leechor leechor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit e9762b0 into DataLinkDC:dev Oct 12, 2023
13 checks passed
leechor pushed a commit to leechor/dinky that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor refactor code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants