Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP is prohibited in conflict with the local user. #2050

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

gaoyan1998
Copy link
Contributor

@gaoyan1998 gaoyan1998 commented Jun 9, 2023

Purpose of the pull request

LDAP与本地用户同时存在且用户名相同情况下,禁止ldap登录
close #2051

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@gaoyan1998 gaoyan1998 self-assigned this Jun 9, 2023
@gaoyan1998 gaoyan1998 added the Fixing The bug is fixing label Jun 9, 2023
@gaoyan1998 gaoyan1998 added this to the 0.8.0 milestone Jun 9, 2023
@gaoyan1998 gaoyan1998 added New Feature New feature and removed Fixing The bug is fixing labels Jun 9, 2023
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit c134995 into DataLinkDC:dev Jun 10, 2023
@gaoyan1998 gaoyan1998 deleted the ldap-some-fix branch July 17, 2023 08:22
@gaopeng666
Copy link

LDAP与本地用户同时存在且用户名相同情况下,优先使用LDAP用户密码,如果使用了本地用户密码登录应该拒绝,这样会不会合理一些

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Optimization][admin] LDAP is prohibited in conflict with the local user
3 participants