Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add official add jar sql syntax, and rename custom add jar to add customJar #1927

Merged
merged 16 commits into from
May 7, 2023

Conversation

leechor
Copy link
Contributor

@leechor leechor commented May 4, 2023

the add jar syntax in dinky cover the official add jar now. they are not equivalent.

@leechor leechor marked this pull request as draft May 4, 2023 14:00
leechor added 2 commits May 4, 2023 22:05
@leechor leechor changed the title feat: add official add jar sql syntax, and rename cusom 'add jar' to 'add customJar' feat: add official add jar sql syntax, and rename custom add jar to add customJar May 4, 2023
leechor and others added 4 commits May 4, 2023 22:37
@leechor leechor marked this pull request as ready for review May 5, 2023 04:14
@aiwenmo aiwenmo added the New Feature New feature label May 5, 2023
@aiwenmo aiwenmo added this to the 0.8.0 milestone May 5, 2023
@aiwenmo aiwenmo requested a review from zackyoungh May 5, 2023 13:33
leechor and others added 2 commits May 6, 2023 21:20
Signed-off-by: Licho <lecho.sun@gmail.com>
Copy link
Contributor

@zackyoungh zackyoungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 21c1dec into DataLinkDC:dev May 7, 2023
zackyoungh pushed a commit to zackyoungh/dinky that referenced this pull request May 8, 2023
…to `add customJar` (DataLinkDC#1927)

* feat: add official add jar sql syntax

* Spotless Apply

* refact

Signed-off-by: Licho <lecho.sun@gmail.com>

* refactor: add log add reduce code

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

* fix: unit test

Signed-off-by: Licho <lecho.sun@gmail.com>

* feat: add configure combination initialize

Signed-off-by: Licho <lecho.sun@gmail.com>

* Spotless Apply

* fix: adapter 1.13

* spotless

* fix: configure import

* Spotless Apply

* fix: flink 1.14 adaptically

* Spotless Apply

---------

Signed-off-by: Licho <lecho.sun@gmail.com>
Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>
Zzm0809 added a commit that referenced this pull request May 23, 2023
* add python sse

* feat: add official `add jar` sql syntax, and rename custom `add jar` to `add customJar` (#1927)

* feat: add official add jar sql syntax

* Spotless Apply

* refact

Signed-off-by: Licho <lecho.sun@gmail.com>

* refactor: add log add reduce code

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

* fix: unit test

Signed-off-by: Licho <lecho.sun@gmail.com>

* feat: add configure combination initialize

Signed-off-by: Licho <lecho.sun@gmail.com>

* Spotless Apply

* fix: adapter 1.13

* spotless

* fix: configure import

* Spotless Apply

* fix: flink 1.14 adaptically

* Spotless Apply

---------

Signed-off-by: Licho <lecho.sun@gmail.com>
Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>

* Add error show modal (#1948)

* [Feature][dinky-web] support git ci/cd web (#1941)

* added git project

* 实现 git(ci/cd) 的web一些功能点

* added some note

* delete some code

* format code

* add python sse

* add python sse

* Update front-end display

* Update front-end display

* Update front-end display

* fix dinky-web build

* fix dinky-web build

---------

Signed-off-by: Licho <lecho.sun@gmail.com>
Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: Licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>
Co-authored-by: gaoyan <34333571+gaoyan1998@users.noreply.github.com>
Co-authored-by: zhu-mingye <934230207@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants