-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add official add jar
sql syntax, and rename custom add jar
to add customJar
#1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leechor
changed the title
feat: add official add jar sql syntax, and rename cusom 'add jar' to 'add customJar'
feat: add official May 4, 2023
add jar
sql syntax, and rename custom add jar
to add customJar
Signed-off-by: licho <lecho.sun@gmail.com>
Signed-off-by: Licho <lecho.sun@gmail.com>
Signed-off-by: Licho <lecho.sun@gmail.com>
zackyoungh
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaoyan1998
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zackyoungh
pushed a commit
to zackyoungh/dinky
that referenced
this pull request
May 8, 2023
…to `add customJar` (DataLinkDC#1927) * feat: add official add jar sql syntax * Spotless Apply * refact Signed-off-by: Licho <lecho.sun@gmail.com> * refactor: add log add reduce code Signed-off-by: licho <lecho.sun@gmail.com> * Spotless Apply * fix: unit test Signed-off-by: Licho <lecho.sun@gmail.com> * feat: add configure combination initialize Signed-off-by: Licho <lecho.sun@gmail.com> * Spotless Apply * fix: adapter 1.13 * spotless * fix: configure import * Spotless Apply * fix: flink 1.14 adaptically * Spotless Apply --------- Signed-off-by: Licho <lecho.sun@gmail.com> Signed-off-by: licho <lecho.sun@gmail.com> Co-authored-by: leechor <leechor@users.noreply.github.com>
Zzm0809
added a commit
that referenced
this pull request
May 23, 2023
* add python sse * feat: add official `add jar` sql syntax, and rename custom `add jar` to `add customJar` (#1927) * feat: add official add jar sql syntax * Spotless Apply * refact Signed-off-by: Licho <lecho.sun@gmail.com> * refactor: add log add reduce code Signed-off-by: licho <lecho.sun@gmail.com> * Spotless Apply * fix: unit test Signed-off-by: Licho <lecho.sun@gmail.com> * feat: add configure combination initialize Signed-off-by: Licho <lecho.sun@gmail.com> * Spotless Apply * fix: adapter 1.13 * spotless * fix: configure import * Spotless Apply * fix: flink 1.14 adaptically * Spotless Apply --------- Signed-off-by: Licho <lecho.sun@gmail.com> Signed-off-by: licho <lecho.sun@gmail.com> Co-authored-by: leechor <leechor@users.noreply.github.com> * Add error show modal (#1948) * [Feature][dinky-web] support git ci/cd web (#1941) * added git project * 实现 git(ci/cd) 的web一些功能点 * added some note * delete some code * format code * add python sse * add python sse * Update front-end display * Update front-end display * Update front-end display * fix dinky-web build * fix dinky-web build --------- Signed-off-by: Licho <lecho.sun@gmail.com> Signed-off-by: licho <lecho.sun@gmail.com> Co-authored-by: Licho <lecho.sun@gmail.com> Co-authored-by: leechor <leechor@users.noreply.github.com> Co-authored-by: gaoyan <34333571+gaoyan1998@users.noreply.github.com> Co-authored-by: zhu-mingye <934230207@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
add jar
syntax in dinky cover the officialadd jar
now. they are not equivalent.