Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor][admin,web] refactor alert group #1895

Merged
merged 4 commits into from
Apr 18, 2023
Merged

[Refactor][admin,web] refactor alert group #1895

merged 4 commits into from
Apr 18, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Apr 18, 2023

Purpose of the pull request

refactor alert group

Brief change log

list

image

create

image

image

update

image

delete

image

@Zzm0809 Zzm0809 marked this pull request as draft April 18, 2023 08:47
@Zzm0809 Zzm0809 requested review from leechor and aiwenmo April 18, 2023 08:47
leechor
leechor approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@leechor leechor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 marked this pull request as ready for review April 18, 2023 09:14
@Zzm0809 Zzm0809 requested a review from zackyoungh April 18, 2023 09:40
@aiwenmo aiwenmo added the Refactor refactor code label Apr 18, 2023
@aiwenmo aiwenmo added this to the 0.8.0 milestone Apr 18, 2023
aiwenmo
aiwenmo approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 566be09 into DataLinkDC:dev Apr 18, 2023
@Zzm0809 Zzm0809 linked an issue Apr 19, 2023 that may be closed by this pull request
[Refactor][web] refactor alert group #1819
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiwenmo aiwenmo aiwenmo approved these changes

@leechor leechor leechor approved these changes

@zackyoungh zackyoungh Awaiting requested review from zackyoungh

Assignees

@Zzm0809 Zzm0809

Labels
Refactor refactor code
Projects
Dinky Roadmap
Archived in project
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[Refactor][web] refactor alert group
3 participants
@Zzm0809 @leechor @aiwenmo