Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][dinky-web] added global var list for dinky-web #1815

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Mar 31, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809
Copy link
Contributor Author

Zzm0809 commented Mar 31, 2023

image

image

image

image

image

image

image

@aiwenmo aiwenmo added the New Feature New feature label Mar 31, 2023
@aiwenmo aiwenmo added this to the 0.8.0 milestone Mar 31, 2023
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit ac84664 into DataLinkDC:dev Mar 31, 2023
@Zzm0809 Zzm0809 mentioned this pull request Apr 1, 2023
50 tasks
@Zzm0809 Zzm0809 added the Refactor refactor code label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature Refactor refactor code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants