Skip to content

[FIX]: maybe have empty primary key statement when no primary key #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2023
Merged

[FIX]: maybe have empty primary key statement when no primary key #1767

merged 2 commits into from
Mar 25, 2023

Conversation

leechor
Copy link
Contributor

@leechor leechor commented Mar 23, 2023

No description provided.

@leechor leechor requested a review from Zzm0809 March 24, 2023 06:02
aiwenmo
aiwenmo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo added the Bug Something isn't working label Mar 24, 2023
@aiwenmo aiwenmo added this to the 0.8.0 milestone Mar 24, 2023
Zzm0809
Zzm0809 reviewed Mar 25, 2023
View reviewed changes
Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit de772eb into DataLinkDC:dev Mar 25, 2023
@aiwenmo aiwenmo mentioned this pull request Mar 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zzm0809 Zzm0809 Zzm0809 left review comments

@aiwenmo aiwenmo aiwenmo approved these changes

Assignees

@leechor leechor

Labels
Bug Something isn't working
Projects
Dinky Roadmap
Archived in project
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@leechor @aiwenmo @Zzm0809