Skip to content

Conversation

killmytime
Copy link
Contributor

这里半角单引号打错啦,打的重音符合,这样实际存的是 `value` 而不是 value

Purpose of the pull request

修复dinky 中文文档中 Flink SQL开发指南部分SET语句中的错误示例描述,示例上方描述是准确的,但是给的示例是错误的。
image

Brief change log

将示例中的

SET `key`=`value`;

中的重音符改为

SET 'key'='value'

半角单引号

Verify this pull request

我在flink1.13.5对应的sqlclient中做了验证
使用重音符(`)的case:
image
使用单引号(')的case:
image

这里半角单引号打错啦,打的重音符合,这样实际存的是`value`而不是value
@leechor leechor requested a review from Zzm0809 February 7, 2023 03:31
Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit c738cf8 into DataLinkDC:dev Feb 7, 2023
Zzm0809 pushed a commit to Zzm0809/dinky that referenced this pull request Feb 8, 2023
这里半角单引号打错啦,打的重音符合,这样实际存的是`value`而不是value
@aiwenmo aiwenmo added the Doc Improvements or additions to documentation label Feb 28, 2023
@aiwenmo aiwenmo added this to the 0.8.0 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants