Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add actionType and refact clinet-base and common Table class #1588

Merged
merged 14 commits into from
Feb 1, 2023
Merged

test: add actionType and refact clinet-base and common Table class #1588

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a17966d
test: add actionType
leechor Feb 1, 2023
da2cc29
style: spotless
leechor Feb 1, 2023
5ea702c
feat: run unit test
leechor Feb 1, 2023
0891c13
feat: github workflow remove fast profile
leechor Feb 1, 2023
d2e1218
test: ignore class unit test
leechor Feb 1, 2023
c01feff
test: remove invalid test from daemon
leechor Feb 1, 2023
33a987b
refactor: Table getFlinkDDL function, and extract FlinkCDCConfig conf…
leechor Feb 1, 2023
1d686be
refactor: Table getFlinkDDL function, and extract FlinkCDCConfig conf…
leechor Feb 1, 2023
a9964df
style: spotless
leechor Feb 1, 2023
c1b5e66
style: spotless
leechor Feb 1, 2023
30bfd54
fix: compatible for jdk8
leechor Feb 1, 2023
13a7573
fix: Column need default construct
leechor Feb 1, 2023
fb37f9b
refactor: transfer log language
leechor Feb 1, 2023
0ae167a
refactor: simply code
leechor Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: compatible for jdk8
  • Loading branch information
@leechor
leechor committed Feb 1, 2023
commit 30bfd54aceb68074e9cf1240b911511f85b1130e
8 changes: 6 additions & 2 deletions dinky-common/src/main/java/org/dinky/model/Table.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.io.Serializable;
import java.text.MessageFormat;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -100,8 +101,11 @@ public static Table build(String name, String schema, List<Column> columns) {
@Transient
public String getFlinkTableWith(String flinkConfig) {
if (Asserts.isNotNullString(flinkConfig)) {
return SqlUtil.replaceAllParam(
flinkConfig, Map.of("schemaName", schema, "tableName", name));
Map<String, String> replacements = new HashMap<>();
replacements.put("schemaName", schema);
replacements.put("tableName", name);

return SqlUtil.replaceAllParam(flinkConfig, replacements);
}
return "";
}
Expand Down