Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI page display misalignment fix #1013

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

gaoyan1998
Copy link
Contributor

Purpose of the pull request

UI page display misalignment fix

Brief change log

change global.less

Verify this pull request

The overall UI has the problem of padding disappearing, including the low menu height, which is especially obvious on the data source page. The first one has exceeded the limit.
bug3.png
bug2.png

It may be a global configuration problem
Just remove the code .ant-pro-card-body and .ant-tabs-nav from global.less can be fix.
maybe just a small diff,but it affects the browsing experience
fix2.png
fix1.png

@aiwenmo aiwenmo linked an issue Sep 9, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit c8d7141 into DataLinkDC:dev Sep 9, 2022
aiwenmo added a commit that referenced this pull request Sep 12, 2022
* [Fix][admin,web,app,core] Fix rc1 bugs (#1007)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* alter error (#1011)

* [Optimization-1014][client] Optimizate Doris sink and type convert and upgrade flink to 1.15.2 (#1015)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* UI page display misalignment fix (#1013)

Co-authored-by: steve <woai1998>

* out.collect在字段报错时没有上级抛错误,e.getCause().getMessage()会打不出错误栈,打印修改为logger.error("..",e). (#1016)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
Co-authored-by: toms <94617906+Toms1999@users.noreply.github.com>
Co-authored-by: ikiler <34333571+ikiler@users.noreply.github.com>
Co-authored-by: mengyejiang <403905717@qq.com>
aiwenmo added a commit that referenced this pull request Sep 18, 2022
* [Fix][admin,web,app,core] Fix rc1 bugs (#1007)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* alter error (#1011)

* [Optimization-1014][client] Optimizate Doris sink and type convert and upgrade flink to 1.15.2 (#1015)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* UI page display misalignment fix (#1013)

Co-authored-by: steve <woai1998>

* out.collect在字段报错时没有上级抛错误,e.getCause().getMessage()会打不出错误栈,打印修改为logger.error("..",e). (#1016)

* Update cdcsource_statements.md (#1018)

cdcsource增加支持多目标库同步功能。

* Sqlserver fix 完善字段查询、字段类型判断功能 (#1021)

* Update cdcsource_statements.md

cdcsource增加支持多目标库同步功能。

* sqlserver优化字段属性类型解析.
sqlserver字段sql查询语句优化增加获取字段长度.

* sqlserver优化字段属性类型解析.
sqlserver字段sql查询语句优化增加获取字段长度.

Co-authored-by: 金鑫 <jinyanhui@huansi.net>

* [Fix-1020][core,web] Fix error in saving task after modifying task name (#1023)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* 修复sqlservercdc时decimal是base64的bug (#1026)

* Update cdcsource_statements.md

cdcsource增加支持多目标库同步功能。

* sqlserver优化字段属性类型解析.
sqlserver字段sql查询语句优化增加获取字段长度.

Co-authored-by: 金鑫 <jinyanhui@huansi.net>

* [Feature-1027][admin,web] Add data development task information log details button (#1029)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
Co-authored-by: toms <94617906+Toms1999@users.noreply.github.com>
Co-authored-by: ikiler <34333571+ikiler@users.noreply.github.com>
Co-authored-by: mengyejiang <403905717@qq.com>
Co-authored-by: 金鑫 <jinxin@qdjinxin.net>
Co-authored-by: 金鑫 <jinyanhui@huansi.net>
@gaoyan1998 gaoyan1998 deleted the bug-fix-ui-padding branch October 11, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [web] UI page display misalignment
2 participants