Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return address to lock & signal #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

festelo
Copy link
Collaborator

@festelo festelo commented May 11, 2021

No description provided.

Copy link
Contributor

@ltfschoen ltfschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've proposed some changes in branch 'luke/ilya/MMD-1023'.

maybe change the order of the parameters like returnAddress, but this will impact calls from DataDash, so may cause unnecessary extra work.

and we don't need returnAddress for signalling, as they aren't locking any tokens. so it's only necessary for locking

ideally we could update the tests to check it locks the tokens and returns them to the returnAddress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants