Skip to content

updated textservice to not catch empty strings #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

updated textservice to not catch empty strings #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bca6e7
updated textservice to not catch empty strings
sidmohan0 May 7, 2025
48c4c1e
Merge branch 'dev' into chore/housekeeping
sidmohan0 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions datafog/services/text_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ def _annotate_with_engine(
# Try regex first
regex_dict = self.regex_annotator.annotate(text)

# Check if any entities were found
# Check if any VALID entities were found (ignore empty strings)
has_entities = any(
len(entities) > 0 for entities in regex_dict.values()
any(entity.strip() for entity in entities)
for entities in regex_dict.values()
)

# If regex found entities, return those results
Expand Down