-
Notifications
You must be signed in to change notification settings - Fork 1
Add feature to add and delete labels to selected nodes #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ideas discussed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR and the majority of features work as intended, thank you. I only noticed two things:
- Drag n drop of labels is not possible anymore. We said that we want to still support it, if it is possible without major effort. What was your finding here?
- Selecting multiple is not possible by drawing a selection box with the left mouse button as discussed. If this this would cause a major change, we can also merge this PR first and then add it later, what do you think?
This works for me. Can you quickly walk me through the process, so I can make sure we talk about the same feature
We agreed on doing this separately due to it being a bigger change |
I meant dragging and dropping labels, which should perform the same action as clicking (applying them to all selected nodes) |
The bug was only present on Chromium based browsers. |
When having no node selected, the label will be added to all nodes
When having a selection of nodes, the label will be added to the selected nodes only.
fixes DataFlowAnalysis/DataFlowAnalysis#274