This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Feat: Changing control flow naming to tilde #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the converter side of DataFlowAnalysis/WebEditor#51. However, I suggest we merge this before the Editor is adjusted. While both the old and new syntax dont get accepted by the Editor, the new at least allows From-PCM-Created-Jsons to be converted into DFD's again |
|
Needs adjustments from @Kr0nox in the web editor |
|
@sebinside @Nicolas-Boltz @uuqjz review plz |
uuqjz
suggested changes
Dec 3, 2024
....dataflowanalysis.converter/src/org/dataflowanalysis/converter/DataFlowDiagramConverter.java
Outdated
Show resolved
Hide resolved
....dataflowanalysis.converter/src/org/dataflowanalysis/converter/DataFlowDiagramConverter.java
Show resolved
Hide resolved
Nicolas-Boltz
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing control flow naming to ~ from empty.
Adds additional ~ for multiple incoming control flows to ensure unique names.