Fix link on symlinked README.md #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README.md file in the directory arrow2_convert_derive is a symlink to this README.md file, however the link is broken if I click from that directory. The link once results in: `https://github.com/DataEngineeringLabs/arrow2-convert/blob/main/arrow2_convert_derive/arrow2_convert/tests/complex_example.rs` which is a 404. I think the same happened to me when I clicked on the docs.rs Making the link absolute to try to fix the current 404 I get when I try to follow the link.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 94.58% 94.83% +0.25%
==========================================
Files 8 8
Lines 1589 1589
==========================================
+ Hits 1503 1507 +4
+ Misses 86 82 -4 |
|
Thank you @sebosp for your PR! |
|
Thank you for an awesome tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README.md file in the directory arrow2_convert_derive is a symlink to this README.md file, however the link is broken if I click from that directory. The link once results in:
https://github.com/DataEngineeringLabs/arrow2-convert/blob/main/arrow2_convert_derive/arrow2_convert/tests/complex_example.rswhich is a 404.I think the same happened to me when I clicked on the docs.rs
Making the link absolute to try to fix the current 404 I get when I try to follow the link.