fix existing tag config check

datadog/resource_datadog_metric_tag_configuration.go

@@ -160,8 +160,17 @@ func resourceDatadogMetricTagConfigurationCreate(d *schema.ResourceData, meta in
 	metricName := d.Get("metric_name").(string)
 
 	// check if the tag configuration already exists, if so return an error
-	_, httpresp, _ := datadogClient.MetricsApi.ListTagConfigurationByName(auth, metricName).Execute()
-	if httpresp.StatusCode == 200 {
+	_, httpresp, err := datadogClient.MetricsApi.ListTagConfigurationByName(auth, metricName).Execute()
+	if err != nil || httpresp == nil {
+		if httpresp != nil && httpresp.StatusCode != 404 {
+			return utils.TranslateClientError(err, "could not determine if metric already exists")
+		}
+		if httpresp == nil {
+			return fmt.Errorf("error creating MetricTagConfiguration: could not determine if metric already exists")
+		}
+		// if neither of these cases hit is it ok because the api will return 404 when we can create a tag-configuration
+	}
+	if httpresp != nil && httpresp.StatusCode == 200 {
 		return fmt.Errorf("error creating MetricTagConfiguration: a tag configuration already exists for metric, import it first")
 	}
 

datadog/tests/provider_test.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"crypto/sha256"
 	"fmt"
-	"github.com/terraform-providers/terraform-provider-datadog/datadog/internal/utils"
 	"io/ioutil"
 	"log"
 	"net/http"
@@ -18,6 +17,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/terraform-providers/terraform-provider-datadog/datadog/internal/utils"
+
 	"github.com/terraform-providers/terraform-provider-datadog/datadog"
 
 	datadogV1 "github.com/DataDog/datadog-api-client-go/api/v1/datadog"
@@ -440,6 +441,10 @@ func buildDatadogClientV1(httpClient *http.Client) *datadogV1.APIClient {
 func buildDatadogClientV2(httpClient *http.Client) *datadogV2.APIClient {
 	//Datadog V2 API config.HTTPClient
 	configV2 := datadogV2.NewConfiguration()
+	configV2.SetUnstableOperationEnabled("CreateTagConfiguration", true)
+	configV2.SetUnstableOperationEnabled("DeleteTagConfiguration", true)
+	configV2.SetUnstableOperationEnabled("ListTagConfigurationByName", true)
+	configV2.SetUnstableOperationEnabled("UpdateTagConfiguration", true)
 	configV2.Debug = isDebug()
 	configV2.HTTPClient = httpClient
 	configV2.UserAgent = utils.GetUserAgent(configV2.UserAgent)