Handle 0 in monitor new_host_delay #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Terraform doesn't return 0 values on fields, but it's appropropriate for new_host_delay on the monitor resource. Let's make sure we send it in this case.
therve
force-pushed
the
therve/monitor-zero-host-delay
branch
from
527819b to
a9c5f15
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
reviewed
Oct 28, 2020
| o.SetNewHostDelay(int64(attr.(int))) | ||
| } | ||
| // Don't check with GetOk, doesn't work with 0 | ||
| o.SetNewHostDelay(int64(d.Get("new_host_delay").(int))) |
There was a problem hiding this comment.
What if new_host_delay isn't actually set ? This will error out no ?
There was a problem hiding this comment.
There is a default so it should always be set I think.
There was a problem hiding this comment.
Ah ok, do we have a test case for it to make sure ?
There was a problem hiding this comment.
Yeah tests like TestAccDatadogMonitor_SilencedRemove ought to trigger this.
zippolyte
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform doesn't return 0 values on fields, but it's appropropriate for
new_host_delay on the monitor resource. Let's make sure we send it in
this case.