Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate query field of pipeline filter #605

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

therve
Copy link
Contributor

@therve therve commented Jul 29, 2020

If query is empty, the filter we try to build is an empty map (even if
it has a length...), so casting will fail. Validate the field so that it
doesn't happen.

Closes #572

If query is empty, the filter we try to build is an empty map (even if
it has a length...), so casting will fail. Validate the field so that it
doesn't happen.

Closes #572
@therve therve merged commit 16fcd76 into master Jul 29, 2020
@therve therve deleted the therve/empty-pipeline-query branch July 29, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: rpc error: code = Canceled desc = context canceled
2 participants