[datadog_sensitive_data_standard_pattern] add description and deprecate pattern #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinckama
force-pushed
the
vincent.roy/2371
branch
from
ee03700 to
a05e684
Compare
urseberry
previously approved these changes
Dec 4, 2024
fbryden
reviewed
Dec 5, 2024
| "pattern": { | ||
| Description: "Regex that the standard pattern applies.", | ||
| Description: "Regex to match, optionally documented for older standard rules. ", |
There was a problem hiding this comment.
optionally documented for older standard rules.
I'm sorry I'm not sure what you mean by this
There was a problem hiding this comment.
Ok but I see what you did in terms of aligning with the public doc
fbryden
reviewed
Dec 5, 2024
skarimo
previously approved these changes
Dec 6, 2024
skarimo
dismissed stale reviews from fbryden, urseberry, and themself
via
8538261
skarimo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the
datadog_sensitive_data_standard_patternresource with the Public API to list standard patternsdescriptionattribute.patternattribute.