Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_synthetics_test] Fix missing default value for browser variables #1884

Merged
merged 2 commits into from
Apr 21, 2023
Merged

[datadog_synthetics_test] Fix missing default value for browser variables #1884

merged 2 commits into from
Apr 21, 2023

Conversation

romainberger
Copy link
Member

This PR fixes some missing default values for browser_variable.

This configuration currently fails:

browser_variable {
    name = "VAR_EMAIL"
    type = "email"
  }

the variable needs a pattern and an example but they don't really make sense for the user, although they are required in the backend.

@romainberger romainberger requested review from a team as code owners April 21, 2023 13:37
@nkzou nkzou merged commit b01a0f9 into master Apr 21, 2023
@nkzou nkzou deleted the rberger/browser-variable-fix branch April 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkzou nkzou nkzou approved these changes

Assignees
No one assigned
Labels
changelog/bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainberger @nkzou