Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Add DiffSupressFunc for rum settings #1532

Conversation

bhaoui
Copy link
Contributor

@bhaoui bhaoui commented Aug 17, 2022

Add suppressDiffFunc for rum settings when local state is nil and remote is false, for s8s browser tests.

The goal is to suppress rum_settings diff if rum_settings.is_enabled is false.

@bhaoui bhaoui changed the title [Synthetics] Add suppressDiffFunc for rum settings when local state i… [Synthetics] Add suppressDiffFunc for rum settings Aug 17, 2022
@bhaoui bhaoui force-pushed the SYA-1847-add-suppress-diff-func-for-rum-settings-when-local-state-is-nil-and-remote-is-false branch 5 times, most recently from 6232f50 to ef41d22 Compare August 18, 2022 14:56
@bhaoui bhaoui marked this pull request as ready for review August 18, 2022 15:15
@bhaoui bhaoui requested review from a team as code owners August 18, 2022 15:15
@bhaoui bhaoui force-pushed the SYA-1847-add-suppress-diff-func-for-rum-settings-when-local-state-is-nil-and-remote-is-false branch from ef41d22 to 1fd24bc Compare August 18, 2022 15:26
@bhaoui bhaoui force-pushed the SYA-1847-add-suppress-diff-func-for-rum-settings-when-local-state-is-nil-and-remote-is-false branch from 1fd24bc to ba91ed0 Compare August 18, 2022 15:27
@therve therve changed the title [Synthetics] Add suppressDiffFunc for rum settings [datadog_synthetics_test] Add DiffSupressFunc for rum settings Aug 22, 2022
@therve therve merged commit 90baea2 into master Aug 22, 2022
@therve therve deleted the SYA-1847-add-suppress-diff-func-for-rum-settings-when-local-state-is-nil-and-remote-is-false branch August 22, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants