Skip to content

Conversation

@duncanpharvey
Copy link
Collaborator

What does this PR do?

  • Update license to use boilerplate copyright
  • Add 'present' to copyright notice

Motivation

Follow open source guidelines

Additional Notes

Describe how to test/QA your changes

@duncanpharvey duncanpharvey requested a review from a team as a code owner June 24, 2025 14:34
identification within third-party archives.

Copyright 2024 Datadog, Inc.
Copyright [yyyy] [name of copyright owner]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get slotted in somewhere when people look at it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the actual copyright information is in the NOTICE file. Is that what you're asking?

Copyright 2024-Present Datadog, Inc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When someone looks at this are they going to see [yyyy] [name of copyright owner] or 2024-Present Datadog, Inc? I'm not too familiar with licensing things but it would seem strange to me to have a placeholder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will see Copyright [yyyy] [name of copyright owner] in the LICENSE file. My understanding is that the LICENSE file is a set of instructions which should not be modified. I incorrectly modified it when I originally created this repo. The actual copyright information is in the NOTICE file.

https://opensource.stackexchange.com/questions/12594/is-an-apache-2-0-license-with-missing-appendix-notice-on-files-valid

The appendix is a set of instructions. It is intended to describe the recommended best practice for licensing your own code under the Apache License. It is not part of the license itself.

@duncanpharvey duncanpharvey merged commit ff6b8d6 into main Jun 24, 2025
4 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/license-notice branch June 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants