chore: update all the datadog layer versions #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanpharvey
requested changes
Nov 27, 2024
Collaborator
duncanpharvey
left a comment
duncanpharvey
left a comment
There was a problem hiding this comment.
Looks good with one small fix
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
+1
to
+3
| exports.lambda_handler = function (event, context) { | ||
| context.succeed('Hello!'); | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
|
|
||
| tags = { | ||
| dd_sls_terraform_module = "1.5.0" | ||
| dd_sls_terraform_module = "2.0.0" |
Contributor
Author
There was a problem hiding this comment.
we're going to 2.0.0 because we're bumping the minimum required aws provider version.
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 5.32.0" | ||
| version = ">= 5.77.0" |
Contributor
Author
There was a problem hiding this comment.
this is pushing us to version 2.0.0 for the whole module.
apiarian-datadog
deleted the
aleksandr.pasechnik/update-all-the-default-layer-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.