Repository navigation
Conversation
The test agent's gRPC listener forwards decoded payloads to its HTTP /v1/traces endpoint with an application/x-protobuf content type, so the application/grpc check could never pass. Treat delivery through the gRPC-only port as proof of gRPC, as test_otel_exporter_otlp_protocol.py already does. Java now runs the test and fails on a real tracer bug: OkHttp 3.12.15 drops the required `te: trailers` header, so the gRPC server resets the stream. Declare it as bug (APMAPI-2503) instead of incomplete_test_app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 3c0e861 | Docs | View more details | Give us feedback! |
vpellan
marked this pull request as ready for review
October 16, 2026 14:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MilanGarnier
approved these changes
Oct 16, 2026
Mascarpone
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test_OTEL_EXPORTER_OTLP_TRACES_PROTOCOL::test_grpc_protocol_is_used_for_trace_exportwas declaredincomplete_test_appfor Java, but it could not pass for any library: the test agent's gRPC listener forwards each export to its own HTTP/v1/tracesendpoint withContent-Type: application/x-protobuf, while the test expectedapplication/grpc.Changes
test_otel_exporter_otlp_protocol.pyalready uses. The unusedapplication/grpccontent-type entry is removed. HTTP assertions are unchanged.incomplete_test_app→bug (APMAPI-2503). With the test fixed, Java fails on a real tracer bug:OtlpGrpcSenderdoes not send thete: trailersheader that gRPC requires, and the Datadog OkHttp fork (3.12.15) dropstefrom every HTTP/2 request anyway. The test agent's gRPC server then resets the stream (StreamResetException: stream was reset: INTERNAL_ERRORin the tracer logs). Reproduced with curl against the same agent: the same reset withoutte: trailers,grpc-status: 0with it. APMAPI-2503 already tracks the Java gRPC failures for metrics and logs, which use the same sender.Locally with
TEST_LIBRARY=java: 4 passed, 1 xfailed. No tracer currently exports traces over gRPC, so the new gRPC pass path has only been checked with a hand-sent gRPC export through the test agent.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
🤖 Generated with Claude Code