Repository navigation
fix(aws-ssi): retry stack up in-process on InsufficientInstanceCapacity - #8041
Draft
cbeauchesne wants to merge 1 commit into
Draft
cbeauchesne wants to merge 1 commit into
cbeauchesne wants to merge 1 commit into
Conversation
When the AZ of the randomly chosen subnet has no capacity for the instance type, retry the stack up excluding that subnet, so another AZ can be tried. Also add it to the known infra exceptions, so that if every attempt fails the job exits with code 3 and gets retried by GitLab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
|
cbeauchesne
marked this pull request as ready for review
October 14, 2026 09:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cbeauchesne
marked this pull request as draft
October 14, 2026 14:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Several AWS SSI jobs fail on EC2 capacity errors, e.g. in pipeline 144379440:
This error was neither retried in-process (only
IdempotentParameterMismatchwas) nor listed in the known infra exceptions. So the job failed with exit code 1, and GitLab never retried it.Changes
_stack_up_with_idempotency_retryis renamed to_stack_up_with_retry. It also retries onInsufficientInstanceCapacity: it excludes the subnet that failed, destroys the stack, waits 30s, then runs the stack up again on another subnet (3 attempts in total, same as before)._pick_subnet_idpicks randomly among subnets that haven't failed yet. If all of them have failed, it picks among all subnets.InsufficientInstanceCapacityis added toaws_infra_exceptions.json, so if every attempt fails the job exits with code 3 and GitLab retries it.Note: a retry only reaches another AZ if the subnets in
ONBOARDING_AWS_INFRA_SUBNET_IDare in different AZs.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
🤖 Generated with Claude Code