Repository navigation
Conversation
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 0a79305 | Docs | View more details | Give us feedback! |
1ff02a1 to
8c7e97a
Compare
vpellan
changed the title
The Go helper inferred the log level from the INFO startup line, which is absent once OTEL_LOG_LEVEL=warn or error is honored. The Go parametric app now reports dd_trace_effective_log_level through tracer.AdaptLogger, and the threshold tests are enabled for Go from v2.12.0-dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8c7e97a to
3b6934d
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b6934d3ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if startupLogLevel == "info" && (level == "warn" || level == "error") { | ||
| return "info" |
There was a problem hiding this comment.
When OTEL_LOG_LEVEL is warn or error, the tracer suppresses the INFO startup configuration, so l.tracerConfig remains empty. Although this new path successfully obtains the effective level, the unchanged check later in getTraceConfigHandler interprets that empty map as a disabled tracer and returns dd_trace_enabled: "false" together with blank configuration fields. Thus every /trace/config response under either newly enabled threshold misreports a running tracer; enabled status must no longer be inferred solely from the startup INFO message.
Useful? React with 👍 / 👎.
Enable Test_OTEL_LOG_LEVEL for Go from v2.12.0-dev, so the Go parametric app reports the tracer's threshold directly and no longer caps it with the startup line level. Drop dd_trace_startup_log_level, which no app sets anymore. The startup configuration line is logged at INFO, so at warn and error its absence no longer reports the tracer as disabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
2 participants
Motivation
Enable the Go
OTEL_LOG_LEVELtests from #7841 now that DataDog/dd-trace-go#5559 is merged. That change makesinfo,warnanderrorset the tracer's log threshold. The Go helper read the INFO startup line, which is now absent atwarnanderror.Changes
dd_trace_effective_log_levelfrom the tracer's threshold, read throughtracer.AdaptLogger._log_levelreadsdd_trace_effective_log_levelfor Go, as for Java, Python and Ruby.Test_OTEL_LOG_LEVELfor Go fromv2.12.0-dev. Older tracers store awarnthreshold by default but still print INFO, so the threshold does not match their output.warnanderror, the Go app no longer reportsdd_trace_enabled: falsewhen the INFO startup line is missing. It leaves the field out, since the line's absence does not show whether the tracer is enabled.dd_trace_startup_log_level, which no parametric app sets anymore.Validation
./format.sh --checktest_otel_log_level.py,test_otel_env_vars.pyandTest_Parametric_DDTrace_Configlocally against dd-trace-gomain(2.13.0-dev): 18 passed, 1 skipped (the PHP-only probe).🤖 Generated with Claude Code