Skip to content

Multi arch support for base images - #8028

Open
nccatoni wants to merge 9 commits into
mainfrom
nccatoni/base-images-multi-arch
Open

nccatoni wants to merge 9 commits into
mainfrom
nccatoni/base-images-multi-arch

Conversation

@nccatoni

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/system-tests-core
docs/edit/update-docker-images.md                                       @DataDog/system-tests-core
mirror_images.lock.yaml                                                 @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
tests/test_the_test/test_build_base_images.py                           @DataDog/system-tests-reviewers
utils/base_images/build_base_images.py                                  @DataDog/system-tests-core
utils/build/docker/base-images.lock.json                                @DataDog/system-tests-reviewers

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 12 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-8.0 2 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.test_sampling_rates.Test_SamplingRates.test_sampling_rates[apache-mod-8.0] from system_tests_suite
ValueError: Some path has not been transmitted

self = <tests.test_sampling_rates.Test_SamplingRates object at 0x7f1e6422f110>

    def test_sampling_rates(self):
        """Basic test"""
>       assert_all_traces_requests_forwarded(self.paths)

tests/test_sampling_rates.py:118: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
...
Testing the test | System Tests (python, dev) / End-to-end #2 / flask-poc 2 — ❌ 2 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.appsec.waf.test_addresses.Test_Cookies.test_cookies_with_spaces_custom_rules[flask-poc] from system_tests_suite
ValueError: No appsec event validate this condition

self = <tests.appsec.waf.test_addresses.Test_Cookies object at 0x7fa1311de270>

    @scenarios.appsec_custom_rules
    def test_cookies_with_spaces_custom_rules(self):
        """Cookie with pattern containing a space"""
>       interfaces.library.assert_waf_attack(self.r_cwscr_2, pattern="var_dump ()", address="server.request.cookies")

tests/appsec/waf/test_addresses.py:160: 
...
❌ tests.appsec.waf.test_addresses.Test_Cookies.test_cookies_with_special_chars2_custom_rules[flask-poc] from system_tests_suite
ValueError: No appsec event validate this condition

self = <tests.appsec.waf.test_addresses.Test_Cookies object at 0x7fa1311dcdd0>

    @scenarios.appsec_custom_rules
    def test_cookies_with_special_chars2_custom_rules(self):
        """Other cookies patterns"""
>       interfaces.library.assert_waf_attack(self.r_cwsc2cc, pattern='o:4:"x":5:{d}', address="server.request.cookies")

tests/appsec/waf/test_addresses.py:169: 
...
Testing the test | System Tests (python, dev) / End-to-end #2 / uds-flask 2 — ❌ 2 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.appsec.waf.test_addresses.Test_Cookies.test_cookies_with_spaces_custom_rules[uds-flask] from system_tests_suite
ValueError: No appsec event validate this condition

self = <tests.appsec.waf.test_addresses.Test_Cookies object at 0x7fcefc9b88f0>

    @scenarios.appsec_custom_rules
    def test_cookies_with_spaces_custom_rules(self):
        """Cookie with pattern containing a space"""
>       interfaces.library.assert_waf_attack(self.r_cwscr_2, pattern="var_dump ()", address="server.request.cookies")

tests/appsec/waf/test_addresses.py:160: 
...
❌ tests.appsec.waf.test_addresses.Test_Cookies.test_cookies_with_special_chars2_custom_rules[uds-flask] from system_tests_suite
ValueError: No appsec event validate this condition

self = <tests.appsec.waf.test_addresses.Test_Cookies object at 0x7fcefc9b8560>

    @scenarios.appsec_custom_rules
    def test_cookies_with_special_chars2_custom_rules(self):
        """Other cookies patterns"""
>       interfaces.library.assert_waf_attack(self.r_cwsc2cc, pattern='o:4:"x":5:{d}', address="server.request.cookies")

tests/appsec/waf/test_addresses.py:169: 
...

View all 12 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9bd8c87 | Docs | View more details | Give us feedback!

@nccatoni
nccatoni marked this pull request as ready for review October 12, 2026 11:15
@nccatoni
nccatoni requested review from a team as code owners October 12, 2026 11:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T11:19:42.452761Z f9cdadf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9cdadfc02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/base_images/build_base_images.py Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants