Repository navigation
Conversation
Add the capture-timeout weblog endpoint and line mapping for the Python flask weblog, and enable the guardrail tests that the tracer already supports: - Test_Debugger_Capture_Timeout_Guardrail (v4.13.0) - Test_Debugger_Evaluation_Timeout_Method_Probe (v4.13.0) - Test_Debugger_Snapshot_Size_Guardrail (v2.11.0) - Test_Debugger_Probe_Budgets::test_log_line_capture_expression_budgets (DEBUG-5743 fixed in v4.12.0)
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
|
There was a problem hiding this comment.
More details
The capture-timeout probe targets the return statement where largeCollection is in scope, and the nested fixture passed the child’s smoke check. Full tracer-backed guardrail behavior remains unverified.
🤖 Bits Code Review · Commit f1da4ca · @DataDog review to ask questions
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 314d53f | Docs | View more details | Give us feedback! |
dudikeleti
approved these changes
Oct 8, 2026
…meout Python emits `stack: null` in snapshots for probes whose condition evaluation exceeds the budget, which the schema rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add the capture-timeout weblog endpoint and line mapping for the Python flask weblog, and enable the guardrail tests that the tracer already supports:
Changes
Updated manifests and tests to ensure the guardrails are tested with the appropriate versions.
Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟