Skip to content

Bake public.ecr.aws calls into a base image for nodejs_lambda weblogs - #7868

Closed
nccatoni wants to merge 8 commits into
mainfrom
nccatoni/aws-ecr-base-image-nodejs
Closed

nccatoni wants to merge 8 commits into
mainfrom
nccatoni/aws-ecr-base-image-nodejs

Conversation

@nccatoni

Copy link
Copy Markdown
Collaborator

No description provided.

@nccatoni
nccatoni requested review from a team as code owners September 30, 2026 12:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T12:45:42.749034Z f9eda41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/build/docker/nodejs_lambda/docker-bake.hcl                        @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/runtime.base.Dockerfile                @DataDog/system-tests-reviewers
.github/workflows/update-lambda-extension.yml                           @DataDog/system-tests-core
mirror_images.lock.yaml                                                 @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
utils/build/docker/base-images.lock.json                                @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/nodejs-alb-multi.Dockerfile            @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/nodejs-alb.Dockerfile                  @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/nodejs-apigw-http.Dockerfile           @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/nodejs-apigw-rest.Dockerfile           @DataDog/system-tests-reviewers
utils/build/docker/nodejs_lambda/nodejs-function-url.Dockerfile         @DataDog/system-tests-reviewers
utils/scripts/update_lambda_extension_version.py                        @DataDog/system-tests-core

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9eda4121b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/build/docker/nodejs_lambda/runtime.base.Dockerfile
Comment thread utils/build/docker/nodejs_lambda/docker-bake.hcl
Comment thread mirror_images.yaml
Comment thread utils/build/docker/nodejs_lambda/runtime.base.Dockerfile
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 4 Pipeline jobs failed

Testing the test | System Tests (java, prod) / End-to-end #1 / play 1 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.integrations.test_inferred_proxy.Test_AWS_API_Gateway_Inferred_Span_Creation_v2.test_api_gateway_inferred_span_creation_with_distributed_context[play] from system_tests_suite
ValueError: No span validates this test

self = <tests.integrations.test_inferred_proxy.Test_AWS_API_Gateway_Inferred_Span_Creation_v2 object at 0x7f8d039cb830>

    def test_api_gateway_inferred_span_creation_with_distributed_context(self):
        assert self.r.text == "ok"
    
>       interfaces.library.validate_one_span(
            self.r,
            validator=mandatory_tags_validator_factory(
...
Testing the test | System Tests (golang, dev) / parametric / parametric (1) — ❄️ 1 known flaky test

View more details · View in GitHub Actions

↳ ❄️ Known flaky: tests.parametric.test_headers_tracestate_dd.Test_Headers_Tracestate_DD.test_headers_tracestate_dd_propagate_propagatedtags[library_env0, parametric-golang] from system_tests_suite

Testing the test | System Tests (nodejs_lambda, prod) / Build end-to-end (nodejs-apigw-rest)

View more details · View in GitHub Actions

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad02ae8 | Docs | View more details | Give us feedback!

@nccatoni
nccatoni enabled auto-merge (squash) October 1, 2026 08:39
@nccatoni nccatoni closed this Oct 6, 2026
auto-merge was automatically disabled October 6, 2026 07:20

Pull request was closed

@nccatoni
nccatoni deleted the nccatoni/aws-ecr-base-image-nodejs branch October 6, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants