Repository navigation
Auto-activate python manifest tests - #7863
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
This commit was created from the local commit with hash d261a476ae877b7c90fde4acdb465833d2383bfb.
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe31916547
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/ffe/test_exposures_datadog_agent.py::Test_FFE_Exposure_Caching_Serial_Id_Appears: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (EX-3413) | ||
| component_version: <4.15.2 | ||
| weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado] |
There was a problem hiding this comment.
Restrict FFE activation to implementations of
/ffe
This activation list includes django-poc, django-py3.13, and python3.12, which are no longer marked missing at Python 4.15.2. Those images copy the Django weblog, and a repository-wide search of utils/build/docker/python finds /ffe implemented only by the Flask, FastAPI, and Tornado weblogs. The newly enabled serial-ID tests POST to /ffe (for example, Test_FFE_Exposure_Serial_Id.setup_ffe_exposure_serial_id), so these Django variants will return 404 and fail; remove the Django variants from the repeated FFE activation lists (including the file-level EVP entry) until that endpoint exists.
Useful? React with 👍 / 👎.
| tests/ffe/test_flag_eval_evp.py: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (FFL-2446) | ||
| component_version: <4.15.2 | ||
| weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado] | ||
| - declaration: missing_feature (FFL-2446) | ||
| excluded_weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado] |
There was a problem hiding this comment.
Keep agentless EVP contracts disabled outside Flask
At Python 4.15.2 this file-level rule removes the sole FFL-2446 declaration from both Test_FFE_EVP_Flagevaluation_Egress_Agentless_* classes, so the direct and serverless agentless scenarios will run their @scenario_crash contracts for every listed weblog. The adjacent agentless-configuration test is explicitly scoped to flask-poc at manifests/python.yml:1491-1494, and the parallel direct/serverless exposure contracts remain missing_feature (Not yet implemented) at manifests/python.yml:1498-1500. A passing agent-backed FFE run cannot enable these separate scenario topologies; retain class-specific skips until they are supported, or express a genuinely scenario-specific condition with a decorator. .cursor/rules/test-activation.mdcL33-L35
Useful? React with 👍 / 👎.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 16 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)❄️ No new flaky tests detected Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: fe31916 | Docs | View more details | Give us feedback! |
Automated activation of easy-win tests for python
View nightly workflow run