Skip to content

Auto-activate python manifest tests - #7863

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
auto-python-manifest
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
auto-python-manifest

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for python
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

This commit was created from the local commit with hash d261a476ae877b7c90fde4acdb465833d2383bfb.
@dd-octo-sts
dd-octo-sts Bot enabled auto-merge (squash) September 30, 2026 07:01
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner September 30, 2026 07:01
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/system-tests-reviewers

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe31916547

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/python.yml
tests/ffe/test_exposures_datadog_agent.py::Test_FFE_Exposure_Caching_Serial_Id_Appears: # TODO: a lower version might be supported
- declaration: missing_feature (EX-3413)
component_version: <4.15.2
weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict FFE activation to implementations of /ffe

This activation list includes django-poc, django-py3.13, and python3.12, which are no longer marked missing at Python 4.15.2. Those images copy the Django weblog, and a repository-wide search of utils/build/docker/python finds /ffe implemented only by the Flask, FastAPI, and Tornado weblogs. The newly enabled serial-ID tests POST to /ffe (for example, Test_FFE_Exposure_Serial_Id.setup_ffe_exposure_serial_id), so these Django variants will return 404 and fail; remove the Django variants from the repeated FFE activation lists (including the file-level EVP entry) until that endpoint exists.

Useful? React with 👍 / 👎.

Comment thread manifests/python.yml
Comment on lines +1529 to +1534
tests/ffe/test_flag_eval_evp.py: # TODO: a lower version might be supported
- declaration: missing_feature (FFL-2446)
component_version: <4.15.2
weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado]
- declaration: missing_feature (FFL-2446)
excluded_weblog: [fastapi, django-poc, uwsgi-poc, django-py3.13, python3.12, flask-poc, uds-flask, tornado]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep agentless EVP contracts disabled outside Flask

At Python 4.15.2 this file-level rule removes the sole FFL-2446 declaration from both Test_FFE_EVP_Flagevaluation_Egress_Agentless_* classes, so the direct and serverless agentless scenarios will run their @scenario_crash contracts for every listed weblog. The adjacent agentless-configuration test is explicitly scoped to flask-poc at manifests/python.yml:1491-1494, and the parallel direct/serverless exposure contracts remain missing_feature (Not yet implemented) at manifests/python.yml:1498-1500. A passing agent-backed FFE run cannot enable these separate scenario topologies; retain class-specific skips until they are supported, or express a genuinely scenario-specific condition with a decorator. .cursor/rules/test-activation.mdcL33-L35

Useful? React with 👍 / 👎.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 16 Pipeline jobs failed

Testing the test | System Tests (python, dev) / End-to-end #2 / django-py3.13 2 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ pytest.internal[django-py3.13] from system_tests_suite
internal error

Traceback (most recent call last):
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 268, in wrap_session
    session.exitstatus = doit(config, session) or 0
                         ^^^^^^^^^^^^^^^^^^^^^
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/_pytest/main.py&#34;, line 321, in _main
    config.hook.pytest_collection(session=session)
  File &#34;/home/runner/work/system-tests/system-tests/venv/lib/python3.12/site-packages/pluggy/_hooks.py&#34;, line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
...
Testing the test | System Tests (python, dev) / End-to-end #2 / fastapi 2 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.ffe.test_flag_eval_evp.Test_FFE_EVP_Flagevaluation_Degradation.test_ffe_evp_flagevaluation_degradation[fastapi] from system_tests_suite
AssertionError: Expected degraded EVP flagevaluation buckets for flag evp-degradation-flag
assert []

self = &lt;tests.ffe.test_flag_eval_evp.Test_FFE_EVP_Flagevaluation_Degradation object at 0x7f0baaa365d0&gt;

    def test_ffe_evp_flagevaluation_degradation(self) -&gt; None:
        for index, response in enumerate(self.responses):
            assert response.status_code == 200, f&#34;Request {index &#43; 1} failed: {response.text}&#34;
    
        events = find_evp_flagevaluation_events(self.flag_key)
...
Testing the test | System Tests (python, dev) / End-to-end #2 / python3.12 2 — ❌ 1 test failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.ffe.test_flag_eval_evp.Test_FFE_EVP_Flagevaluation_Degradation.test_ffe_evp_flagevaluation_degradation[python3.12] from system_tests_suite
AssertionError: Expected degraded EVP flagevaluation buckets for flag evp-degradation-flag
assert []

self = &lt;tests.ffe.test_flag_eval_evp.Test_FFE_EVP_Flagevaluation_Degradation object at 0x7f2bfdf58f80&gt;

    def test_ffe_evp_flagevaluation_degradation(self) -&gt; None:
        for index, response in enumerate(self.responses):
            assert response.status_code == 200, f&#34;Request {index &#43; 1} failed: {response.text}&#34;
    
        events = find_evp_flagevaluation_events(self.flag_key)
...

View all 16 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fe31916 | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants