Skip to content

Remove any calls to public.ecr.aws on critical path for python lambda - #7838

Merged
cbeauchesne merged 9 commits into
mainfrom
cbeauchesne/remive-ecr-calls
Sep 28, 2026
Merged

cbeauchesne merged 9 commits into
mainfrom
cbeauchesne/remive-ecr-calls

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/chainguard/self.update-lambda-extension.sts.yaml                @DataDog/system-tests-core
.github/workflows/update-lambda-extension.yml                           @DataDog/system-tests-core
utils/build/docker/python_lambda/docker-bake.hcl                        @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/runtime.base.Dockerfile                @DataDog/system-tests-reviewers
utils/scripts/update_lambda_extension_version.py                        @DataDog/system-tests-core
mirror_images.lock.yaml                                                 @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
utils/base_images/base_image.py                                         @DataDog/system-tests-core
utils/build/docker/base-images.lock.json                                @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/alb-multi.Dockerfile                   @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/alb.Dockerfile                         @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/apigw-http.Dockerfile                  @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/apigw-rest.Dockerfile                  @DataDog/system-tests-reviewers
utils/build/docker/python_lambda/function-url.Dockerfile                @DataDog/system-tests-reviewers

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 32 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #2 / php-fpm-7.0 2 — ❌ 6 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.stats.test_stats.Test_Client_Stats.test_top_level_service[php-fpm-7.0] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7fc79c0bb680>

    def test_top_level_service(self):
        """Test that the top-level Service field in the stats payload matches the configured base service"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats[php-fpm-7.0] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7fc79c0b93a0>

    def test_client_side_stats(self):
        """Test that client-side stats are properly bucketed in 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats_bucket_alignment[php-fpm-7.0] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7fc79c0b9400>

    def test_client_side_stats_bucket_alignment(self):
        """Test that client-side stats are aligned on 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
↳ and 3 more — View all
Testing the test | System Tests (php, dev) / End-to-end #2 / php-fpm-7.4 2 — ❌ 6 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.stats.test_stats.Test_Client_Stats.test_top_level_service[php-fpm-7.4] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7f0f989bd730>

    def test_top_level_service(self):
        """Test that the top-level Service field in the stats payload matches the configured base service"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats[php-fpm-7.4] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f0f989bc9e0>

    def test_client_side_stats(self):
        """Test that client-side stats are properly bucketed in 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats_bucket_alignment[php-fpm-7.4] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f0f989bc590>

    def test_client_side_stats_bucket_alignment(self):
        """Test that client-side stats are aligned on 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
↳ and 3 more — View all
Testing the test | System Tests (php, dev) / End-to-end #2 / php-fpm-8.1 2 — ❌ 6 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.stats.test_stats.Test_Client_Stats.test_top_level_service[php-fpm-8.1] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7f0a4cb6f680>

    def test_top_level_service(self):
        """Test that the top-level Service field in the stats payload matches the configured base service"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats[php-fpm-8.1] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f0a4cb6e510>

    def test_client_side_stats(self):
        """Test that client-side stats are properly bucketed in 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats_bucket_alignment[php-fpm-8.1] from system_tests_suite
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f0a4cb6dd60>

    def test_client_side_stats_bucket_alignment(self):
        """Test that client-side stats are aligned on 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
↳ and 3 more — View all

View all 32 failed jobs.

⚠️ Warnings

🧪 6 Tests failed in 1 job

Testing the test | main — ❌ 6 tests failed

View more details · View in GitHub Actions

❌ tests.stats.test_stats.Test_Client_Stats.test_top_level_service[apache-mod-7.0] from system_tests_suite   View in Datadog
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7f07b8746fc0>

    def test_top_level_service(self):
        """Test that the top-level Service field in the stats payload matches the configured base service"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats[apache-mod-7.0] from system_tests_suite   View in Datadog
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f07b8746630>

    def test_client_side_stats(self):
        """Test that client-side stats are properly bucketed in 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
❌ tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats_bucket_alignment[apache-mod-7.0] from system_tests_suite   View in Datadog
AssertionError: Should have at least one stats request
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7f07b8746480>

    def test_client_side_stats_bucket_alignment(self):
        """Test that client-side stats are aligned on 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
>       assert len(stats_requests) > 0, "Should have at least one stats request"
...
↳ and 3 more — View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2774881 | Docs | View more details | Give us feedback!

@cbeauchesne
cbeauchesne marked this pull request as ready for review September 28, 2026 15:30
@cbeauchesne
cbeauchesne requested review from a team as code owners September 28, 2026 15:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aed85831d6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/update-lambda-extension.yml
Comment thread .github/workflows/update-lambda-extension.yml
@cbeauchesne
cbeauchesne merged commit 255dc57 into main Sep 28, 2026
2077 of 2110 checks passed
@cbeauchesne
cbeauchesne deleted the cbeauchesne/remive-ecr-calls branch September 28, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants