[system_tests] Fix flaky test_app_started_is_first_message by using seq_id ordering#6387
Open
vlad-scherbich wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
|
|
eba115d to
c14cbfb
Compare
c14cbfb to
a418fd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/PROF-13796
Motivation
test_telemetry.py::Test_Telemetry::test_app_started_is_first_messagewas flaky (e.g. 8 hits in dd-trace-py main CI, 2026). The test asserted thatapp-startedis the first telemetry message, but it used capture order (log file order) instead of send order (seq_id). Capture order can be non-deterministic—when the first captured batch is not the first sent, the test fails.Changes
test_app_started_is_first_message: Useseq_idas the source of truth for ordering. Flatten all lifecycle telemetry (single messages + message-batch payloads), skip non-lifecycle types (sketches,generate-metrics,logs,distributions), group byruntime_id, sort by(seq_id, batch_index), and assert per runtime that the first message isapp-started. This removes dependence on capture/file order.Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present