APPSEC-61442 - SDK integration of SDS scans by AI Guard [system-tests]#6384
APPSEC-61442 - SDK integration of SDS scans by AI Guard [system-tests]#6384
Conversation
|
|
smola
left a comment
There was a problem hiding this comment.
Mostly done, but we also need to add a new casette with a snapshot of the HTTP response from AI Guard for this request, like I did here: #6115
tbh I don't remember how the cassette update was triggered, but it's probably easier to figure out if you set python.yml temporarily set as supported for the latest version to then inspect the failure logs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91b6a65878
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| assert len(sds) > 0, f"No 'sds' found in metastruct {ai_guard}" | ||
| for sd in sds: | ||
| assert _assert_key(sd, "rule_display_name") | ||
| assert _assert_key(sd, "rule_tag") |
There was a problem hiding this comment.
Can't we assert a specific value here ? like
_assert_key(sd, "rule_tag", specific_value)
Motivation
Test that AI Guard sets SDS tags on spans from evaluator response.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present