[system_tests] Fix flaky IAST standalone tests via library_interface_timeout#6377
[system_tests] Fix flaky IAST standalone tests via library_interface_timeout#6377vlad-scherbich wants to merge 13 commits intomainfrom
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
vlad-scherbich
changed the title
vlad-scherbich
force-pushed
the
vlad/unflake_test_asm_standalone
branch
from
8f85efa to
b048484
Compare
vlad-scherbich
force-pushed
the
vlad/unflake_test_asm_standalone
branch
from
8ffe6ab to
1cdbc66
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cdbc66095
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vlad-scherbich
force-pushed
the
vlad/unflake_test_asm_standalone
branch
from
6e3aa92 to
ef911ea
Compare
vlad-scherbich
changed the title
vlad-scherbich
force-pushed
the
vlad/unflake_test_asm_standalone
branch
from
ef911ea to
ca1185b
Compare
Pull request was converted to draft
…sts from their setup funcs
vlad-scherbich
force-pushed
the
vlad/unflake_test_asm_standalone
branch
from
d216ed3 to
06e22f4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06e22f4288
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
Motivation
Flaky tests in
test_asm_standalone.py::Test_IastStandalone_UpstreamPropagation_V2(e.g.test_no_appsec_upstream__no_asm_event__is_kept_with_priority_1__from_0). See PROF-13796.Root cause: traces sometimes weren't flushed to the agent before the scenario shut down the weblog. The tracer sends traces asynchronously; without enough delay, traces could still be buffered when containers stop.
Changes
iast_standalonescenario (utils/_context/_scenarios/__init__.py): Setlibrary_interface_timeout=15so the tracer has 15 seconds to flush traces before the weblog shuts down.test_asm_standalone.py: Remove the per-setup_iast_standalone_wait_for_tracepoll loop. Per-review feedback: avoidwait_forin setup functions (makes the scenario slow when many tests run). Use the globallibrary_interface_timeoutinstead—one delay before shutdown achieves the same effect.Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present