Repository navigation
update python manifest - #6291
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d9603561e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| fastapi: v3.13.0.dev | ||
| tests/appsec/api_security/test_endpoint_discovery.py::Test_Endpoint_Discovery::test_optional_type: irrelevant | ||
| tests/appsec/api_security/test_endpoint_fallback.py: missing_feature | ||
| tests/appsec/api_security/test_endpoint_fallback.py: irrelevant (python weblogs always have http.route) |
There was a problem hiding this comment.
This file-level irrelevant declaration disables every test in tests/appsec/api_security/test_endpoint_fallback.py, including Test_Endpoint_Fallback_With_Route, which explicitly validates the http.route-present path and is still applicable to Python. Because Python weblogs always having http.route only makes the no-route cases irrelevant, this change drops useful coverage instead of narrowing scope; the manifest should target only the route-absent cases rather than the whole file.
Useful? React with 👍 / 👎.
2 participants
Motivation
New api sec tests are irrelevant for python as they only apply for weblogs without http.route.
APPSEC-61171
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present