Skip to content

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented Aug 27, 2025

Motivation

This is still in development for Java and Python here:

But we want to have system-tests upfront to ensure it's functioning correctly for Sept releases.

Refs: DEBUG-4399, RFC here.

Changes

  • Added service_name and env parameters to remote config command builders and senders in utils/_remote_config.py, allowing remote config commands to target specific services and environments. [1] [2] [3]
  • Updated the config payload to include the service_target field, enabling precise control over which service and environment the configuration applies to.
  • Added new test setup and assertions in Test_Debugger_InProduct_Enablement_Exception_Replay to verify exception replay enablement behavior when multiple remote config overrides are present, including service-level and wildcard targeting.
  • Refactored helper methods in the test class to accept service and environment parameters, improving flexibility and reusability.
  • Modified snapshot filtering logic to exclude snapshots created before the test start time, preventing cross-test interference when multiple tests share the same file.
  • Updated send_rc_apm_tracing in utils.py to support the new service and environment parameters, ensuring all remote config commands can be properly targeted. [1] [2]
  • Added a missing import for time to support timestamp-based filtering in tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-4399-3 branch from dd3d2b6 to 0ab3ebe Compare August 27, 2025 16:46
@tylfin tylfin marked this pull request as ready for review August 27, 2025 18:49
@tylfin tylfin requested review from a team as code owners August 27, 2025 18:49
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-4399-3 branch from 0ab3ebe to 5ef7191 Compare August 28, 2025 18:34
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework usage : all good (even if test_inproduct_enablement_exception_replay_apm_multiconfig will be hard to debug, but there are some test design question that should be brainstormed)

I suggest toi get a review from someone familiar with the tested feature

@tylfin tylfin merged commit a76e751 into main Aug 29, 2025
2548 of 2550 checks passed
@tylfin tylfin deleted the tyler.finethy/DEBUG-4399-3 branch August 29, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants