Skip to content

Check for signal tags using the new crashtracker data format too #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Jun 17, 2025

Motivation

If crashtracker is updated to at least 16.0.0 in a library, tests/docker_ssi/test_docker_ssi_crash.py:57 fails. This is because with DataDog/libdatadog#836 the signal tags have changed from signum/signame to si_signo/si_signo_human_readable.

Changes

Adds a check for si_signo.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Jira: PROF-11906

@szegedi szegedi requested a review from a team as a code owner June 17, 2025 10:04
@szegedi szegedi requested review from andrewlock and robertomonteromiguel and removed request for andrewlock June 17, 2025 10:12
@szegedi szegedi enabled auto-merge (squash) June 17, 2025 12:33
@szegedi szegedi merged commit 1aa08ba into main Jun 17, 2025
2397 of 2400 checks passed
@szegedi szegedi deleted the szegedi/crashtracking-update branch June 17, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants