Skip to content

Updating Live Debugger Exception Lines spring-webmvc-3.1 #4680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented May 21, 2025

Motivation

Changes made to spring-webmvc-3.1 in this PR has now changed the lines where Live Debugger tests expect the errors to be thrown. This PR updates the lines that the tests expect the lines to be at.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd changed the title [Java] Updating Live Debugger Exception Lines spring-webmvc-3.1 Updating Live Debugger Exception Lines spring-webmvc-3.1 May 21, 2025
@mhlidd mhlidd marked this pull request as ready for review May 21, 2025 12:27
@mhlidd mhlidd requested review from a team as code owners May 21, 2025 12:27
@tylfin tylfin requested a review from jpbempel May 21, 2025 16:43
@mhlidd mhlidd merged commit ab6cf66 into main May 22, 2025
430 checks passed
@mhlidd mhlidd deleted the mhlidd/update_live_debugger_expected branch May 22, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants