Skip to content

Conversation

@smola
Copy link
Member

@smola smola commented Feb 26, 2025

Motivation

Tests will pass after merging this one: DataDog/dd-trace-java#8178
(needs to be done in lock-step).

APPSEC-54874

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola force-pushed the smola/api-sec-sampling branch 2 times, most recently from 4adf6b7 to f552b68 Compare February 27, 2025 14:11
@smola smola force-pushed the smola/api-sec-sampling branch 6 times, most recently from df68920 to 71c3a39 Compare March 5, 2025 13:28
@smola smola force-pushed the smola/api-sec-sampling branch 2 times, most recently from ecc82ac to 595f5cf Compare March 17, 2025 07:09
@smola smola force-pushed the smola/api-sec-sampling branch from 595f5cf to 7796bb3 Compare March 25, 2025 17:13
@smola smola marked this pull request as ready for review March 25, 2025 17:13
@smola smola requested review from a team as code owners March 25, 2025 17:13
@smola smola force-pushed the smola/api-sec-sampling branch 2 times, most recently from aa2fb9b to 5c77d48 Compare March 26, 2025 14:56
@smola smola requested a review from a team as a code owner March 26, 2025 16:27
@smola smola requested review from vandonr and removed request for a team March 26, 2025 16:27
@smola smola force-pushed the smola/api-sec-sampling branch from 04a33e7 to 1ef00a3 Compare March 27, 2025 08:33
@smola smola enabled auto-merge March 27, 2025 14:48
@smola smola merged commit 4e93ec7 into main Mar 27, 2025
81 checks passed
@smola smola deleted the smola/api-sec-sampling branch March 27, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants