-
Notifications
You must be signed in to change notification settings - Fork 14
Protobuf system test for schema tracking #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ef8b27 to
b4199e2
Compare
35b25a7 to
42cb443
Compare
robertomonteromiguel
requested changes
Mar 3, 2025
smola
reviewed
Mar 4, 2025
Member
smola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the new endpoints should be documented at https://github.com/DataDog/system-tests/blob/main/docs/weblog/README.md
Contributor
Author
|
github CI seems to be stuck ? But otherwise we should be good to go |
robertomonteromiguel
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up on the development of this new feature, only available in Java and dotnet for now.
All languages are supposed to produce the same schema ID when extracting "from" the same proto file, so this is a perfect use case for a system test.
depends on DataDog/dd-trace-dotnet#6647
and DataDog/dd-trace-java#8403
Changes
don't be too afraid by the size of the diff, it's mostly because of the generated files: 4,118 lines for C# and 12,618 lines for java 😅
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present