Skip to content

[nodejs] Fix get_target_branch - "quotes, parens and # (#3952)"" #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iunanua merged 7 commits into from
Feb 3, 2025
Merged

[nodejs] Fix get_target_branch - "quotes, parens and # (#3952)"" #3953

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68994dd
try with an env var
iunanua Jan 31, 2025
b421293
re-run
iunanua Jan 31, 2025
12b3d06
try
iunanua Jan 31, 2025
579d9c4
add comment
iunanua Jan 31, 2025
768057b
run ci
iunanua Feb 3, 2025
97f40f2
run ci again
iunanua Feb 3, 2025
f38bcc2
Merge branch 'main' into igor/fix-get-target-branch
cbeauchesne Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/get_target_branch/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ runs:
id: extract
shell: bash
run: |
branch=$(echo "${{ inputs.text }}" | grep -ioP '\[(?:java|dotnet|python|ruby|php|golang|cpp|agent|nodejs)@[^]]+(?=\])' | tr -d '[:space:]' || true)
branch=$(echo "${INPUTS_TEXT}" | grep -ioP '\[(?:java|dotnet|python|ruby|php|golang|cpp|agent|nodejs)@[^]]+(?=\])' | tr -d '[:space:]' || true)

echo "target-branch=${branch#*@}" >> $GITHUB_OUTPUT

# the preferred approach to handling untrusted input is to set the value of the expression to an intermediate environment variable
env:
INPUTS_TEXT: ${{ inputs.text }}