Skip to content

Conversation

@mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Jan 23, 2025

Motivation

Enable tests that pass due to DataDog/dd-trace-java#8176

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd marked this pull request as ready for review January 23, 2025 17:56
@mhlidd mhlidd requested review from a team as code owners January 23, 2025 17:56
@mhlidd mhlidd merged commit 750c991 into main Jan 24, 2025
52 checks passed
@mhlidd mhlidd deleted the mhlidd/update_java_dynamic_config_manifest branch January 24, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants