Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Already Consistent .NET Tests #3087

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Sep 20, 2024

Motivation

APMAPI-602 where I am in charge of confirming that the expected .NET tests are matching the telemetry expectations and related config system test expectations.

Changes

Updated the .NET parametric service so that we don't set an empty service name and let the tracer pick up the config one when the one used for custom spans is an empty string.

Enabled in the related manifest files the classes where I ran the tests manually and had success passing the tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@link04 link04 added dotnet Pull requests that update .NET code run-parametric-scenario labels Sep 20, 2024
@link04 link04 marked this pull request as ready for review September 20, 2024 18:36
@link04 link04 requested review from a team as code owners September 20, 2024 18:36
@link04 link04 merged commit 9857349 into main Sep 20, 2024
47 of 56 checks passed
@link04 link04 deleted the maximo/enabling-consistent-dotnet-configs branch September 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Pull requests that update .NET code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants