Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Config Consistency Telemetry Test #3069

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Sep 18, 2024

Motivation

Noticed something not matching as expected when trying to run the test locally for .NET to test that DD_SERVICE was returned as expected.

Changes

Instead of using existing data and helper methods, updated the test to look directly for the env var by name as expected in the telemetry based on the new consistency efforts, i.e. DD_TRACE_HTTP_SERVER_ERROR_STATUSES instead of DD_HTTP_SERVER_ERROR_STATUSES which we should change in both Env Var customers can use and returned config name in the respective SDK language config norm file before being able to completely pass the test.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

assert configuration_by_name.get("DD_VERSION").get("value") == "5.2.0"
assert configuration_by_name.get("DD_TRACE_RATE_LIMIT").get("value") == 10
assert (
configuration_by_name.get("DD_TRACE_HEADER_TAGS").get("value") == "User-Agent:my-user-agent,Content-Type."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is case sensitivity an issue here? E,g, User-Agent vs user-agent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah it shouldn't be based on the RFC, I just tried pulling the same values for the configs that is recommended for the others tests in the RFC(swap some around to change them from the defaults):
https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.e0s28phvgd5g

Copy link
Contributor

@khanayan123 khanayan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you for these changes!

@link04 link04 marked this pull request as ready for review September 19, 2024 17:29
@link04 link04 requested review from Kyle-Verhoog and a team as code owners September 19, 2024 17:29
@link04 link04 requested review from wconti27 and removed request for a team September 19, 2024 17:29
@link04 link04 merged commit 99c59f7 into main Sep 20, 2024
283 checks passed
@link04 link04 deleted the maximo/config-consistency-telemetry-test-update branch September 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants