-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Kind in Gitlab to allow kubernetes injection tests to run #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection_gitlab_2' into landerson/kind-in-gitlab-final # Conflicts: # utils/k8s_lib_injection/k8s_datadog_kubernetes.py # utils/k8s_lib_injection/k8s_weblog.py
…lab-final # Conflicts: # tests/k8s_lib_injection/test_k8s_manual_inject.py
randomanderson
changed the title
Enable Kind in Gitlab to allow kubernetes injection tests to run
Configure Kind in Gitlab to allow kubernetes injection tests to run
Sep 17, 2024
robertomonteromiguel
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Laplie!! Update your branch before merge, because there are some changes in the k8s lib injection that are not present on this PR. Probably you need to make some tweaks on the new tests (configure port and host)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, the kubernetes injection tests ran in Github Actions. With the move to one-pipeline, these tests need to run in Gitlab. Running Kind in gitlab doesn't work without the right incantations.
Changes
build
container to talk to thekind
containerbridge
network instead of thekind
network. Only thebridge
network can communicate with the internetexecute_command
to useshlex
because the previouscommand.split()
broke on any complicated command.There were hundreds of variations and commits attempted to get this final solution. While there are only ~100 lines changed in this PR, there were months of work behind it
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present