Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Kind in Gitlab to allow kubernetes injection tests to run #3057

Merged
merged 93 commits into from
Sep 18, 2024

Conversation

randomanderson
Copy link
Contributor

Motivation

Previously, the kubernetes injection tests ran in Github Actions. With the move to one-pipeline, these tests need to run in Gitlab. Running Kind in gitlab doesn't work without the right incantations.

Changes

  • Using the correct ports/ip addresses for the build container to talk to the kind container
  • Running kind in the bridge network instead of the kind network. Only the bridge network can communicate with the internet
  • Changing execute_command to use shlex because the previous command.split() broke on any complicated command.

There were hundreds of variations and commits attempted to get this final solution. While there are only ~100 lines changed in this PR, there were months of work behind it

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@randomanderson randomanderson added the bug Something isn't working label Sep 17, 2024
@randomanderson randomanderson changed the title Enable Kind in Gitlab to allow kubernetes injection tests to run Configure Kind in Gitlab to allow kubernetes injection tests to run Sep 17, 2024
@randomanderson randomanderson marked this pull request as ready for review September 17, 2024 19:48
@randomanderson randomanderson requested a review from a team as a code owner September 17, 2024 19:48
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laplie!! Update your branch before merge, because there are some changes in the k8s lib injection that are not present on this PR. Probably you need to make some tweaks on the new tests (configure port and host)

@randomanderson randomanderson merged commit 53fe59b into main Sep 18, 2024
378 of 384 checks passed
@randomanderson randomanderson deleted the landerson/kind-in-gitlab-final branch September 18, 2024 15:06
@randomanderson randomanderson mentioned this pull request Sep 30, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants