Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet ] fix dotnet v3, redux #2978

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Sep 4, 2024

Motivation

Follow-up from #2962 to fix tests for .NET 3.x release

Changes

  • revert some changes from [dotnet] Adapt weblog/parametric to 3.2 release #2962
    • restore references to /opt/datadog/netcoreapp3.1/Datadog.Trace.dll
    • re-enable DD_TRACE_ENABLED test
    • leave auto-instrumentation disabled by default in parametric tests (CORECLR_ENABLE_PROFILING=0)
    • remove unnecessary reflection meant for Datadog.Trace.Manual.dll
    • leave reflection for GlobalSettings.DebugEnagled
  • fix: use Release configuration in dotnet restore commands to avoid using the Datadog.Trace nuget package (this has been an issue for a few months, but was only recently discovered when we released tracer v3)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel added the dotnet Pull requests that update .NET code label Sep 4, 2024
@lucaspimentel lucaspimentel changed the title [dotnet ]Lpimentel/fix dotnet v3 redux [dotnet ] fix dotnet v3, redux Sep 4, 2024
Copy link
Member Author

lucaspimentel commented Sep 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on Graphite Graphite

@lucaspimentel lucaspimentel mentioned this pull request Sep 4, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant