Add sevice+env case-insensitivity test to TestDynamicConfigV1 #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ygree
force-pushed
the
ygree/remote-config-svc-env-check
branch
from
91612e1 to
6a59ede
Compare
ygree
force-pushed
the
ygree/remote-config-svc-env-check
branch
4 times, most recently
from
6c19161 to
2bf181b
Compare
ygree
requested review from
Yun-Kim,
dougqh,
manuel-alvarez-alvarez,
nayeem-kamal and
smola
robertomonteromiguel
approved these changes
Feb 13, 2024
Kyle-Verhoog
approved these changes
Feb 13, 2024
Member
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
a couple nits, but otherwise lgtm
| assert cfg_state["apply_state"] == 3 | ||
| assert cfg_state["apply_error"] != "" | ||
|
|
||
| @missing_feature(context.library in ["golang"], reason="Not implemented yet") |
Member
There was a problem hiding this comment.
Suggested change
| @missing_feature(context.library in ["golang"], reason="Not implemented yet") |
I think we can rely on the manifest for skipping golang
Contributor
Author
There was a problem hiding this comment.
Not really! Go tracer does a case-sensitive check, so I added this annotation to exclude Go Tracer from this test case only and not from the entire test class.
Member
There was a problem hiding this comment.
oh I see! Yep that makes sense then. Maybe we should update the reason to include that context?
ygree
force-pushed
the
ygree/remote-config-svc-env-check
branch
from
008c45c to
fa492e4
Compare
…e-insensitivity test Split TestDynamicConfigV1 and TestDynamicConfigIgnoreMismatchingTargets Update tests/parametric/test_dynamic_configuration.py
ygree
force-pushed
the
ygree/remote-config-svc-env-check
branch
from
fa492e4 to
4d9a5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The backend normalizes service and env values, so we need a test case that verifies such a scenario to make sure that a Tracer is case-insensitive of env or service name values.
Changes
Add sevice+env case-insensitivity test.
Extract service+env test to TestDynamicConfigV1_ServiceTargets.
Enable TestDynamicConfigV1_ServiceTargets for the Java Tracer v1.30+.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presentsbuild-XXX-imagelabel is present