Fix Datadog Reports #848
Merged
Fix Datadog Reports #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny-jiang
commented
Mar 13, 2025
|
|
||
| - rpm -Uvh https://yum.puppet.com/puppet8-release-el-9.noarch.rpm #installs the puppet-agent repo | ||
| - yum install -y puppet-agent-8.10.0 rubygems ruby-devel procps-ng | ||
| - dnf group install -y "Development Tools" | ||
| - dnf group install -y "Development Tools" --nobest |
There was a problem hiding this comment.
--nobest is to allow installing a lower version that meets package version requirements
tbavelier
reviewed
Mar 14, 2025
| @@ -127,7 +127,7 @@ def process | |||
| Puppet.debug "Sending metrics for #{@msg_host} to Datadog" | |||
| @dog.batch_metrics do | |||
| metrics.each do |metric, data| | |||
| data.each_value do |val| | |||
| data.values.each do |val| # rubocop:disable Style/HashEachMethods | |||
There was a problem hiding this comment.
error that requires this:
2025-03-14T15:12:49.135Z ERROR [qtp2067368747-71] [puppetserver] Puppet Report processor failed: undefined method each_value' for #<Puppet::Util::Metric:0x7317bca6>
tbavelier
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a syntax error in the datadog reports.
Motivation
Bugfix
Additional Notes
Describe your test plan