Review aid for "Store sampling context in the AsyncContextFrame directly"#270
Draft
szegedi wants to merge 12 commits intoszegedi/acf-simple-draft-basefrom
Draft
Review aid for "Store sampling context in the AsyncContextFrame directly"#270szegedi wants to merge 12 commits intoszegedi/acf-simple-draft-basefrom
szegedi wants to merge 12 commits intoszegedi/acf-simple-draft-basefrom
Conversation
time-profiler.ts uses it to pass an AsyncLocalStorage (ALS) as the key. This allows retrieval of context through the ALS, and can open a way for additional context features, like custom labels.
…heir deregistration through StopImpl->Dispose. This was usually not a problem but test-get-value-from-map-profiler.ts creates a profiler without starting it.
This was usually not a problem but test-get-value-from-map-profiler.ts creates a profiler without starting it.
Overall package sizeSelf size: 1.81 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used as an easier review point for #255, as it's diffed to a point after all the initial "revert" commits.
Not meant to be merged.