Enhancement: Keep packages sorted in composer.json #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
reviewed
Jun 21, 2018
| "ext-curl": "*", | ||
| "lib-curl": "*", | ||
| "php": ">=5.3.0" | ||
| "php": ">=5.3.0", |
Member
There was a problem hiding this comment.
Why change the require order ? They no longer seem to be sorted by alphabetical order.
Contributor
Author
There was a problem hiding this comment.
That’s true, according to https://github.com/composer/composer/blob/c917865fe9f62fd0a7fa6db910597ec4259fc7bf/src/Composer/Json/JsonManipulator.php#L110-L146, requirements are sorted by type first, then alphabetically.
Contributor
Author
There was a problem hiding this comment.
If you are interested, take a look at https://localheinz.com/blog/2018/01/15/normalizing-composer.json/.
🤓
Contributor
Author
|
Thank you, @hush-hush! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
composer.json💁♂️ For reference, see https://getcomposer.org/doc/06-config.md#sort-packages.